feat: deprecate older methods, and document adapter options#89
Open
mairo744 wants to merge 3 commits intolaminas:3.3.xfrom
Open
feat: deprecate older methods, and document adapter options#89mairo744 wants to merge 3 commits intolaminas:3.3.xfrom
mairo744 wants to merge 3 commits intolaminas:3.3.xfrom
Conversation
Signed-off-by: mmalac <mmalac@sygic.com>
Contributor
|
@mairo744 maybe you should also modify the doc of v3 and add test for the new method. |
Signed-off-by: mmalac <mmalac@sygic.com>
mairo744
force-pushed
the
feature/deprecate-laminas-json
branch
from
a4c7d3f to
5368c91
Compare
Author
|
I moved the v4 doc directly into the v4 implementation and added tests for the new method in the existing test suite. I also added a note in the v3 documentation about the v4 changes. |
Signed-off-by: mmalac <mmalac@sygic.com>
froschdesign
approved these changes
Mar 25, 2026
Member
|
@fezfez |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR deprecates the usage of laminas-json in the Json adapter and prepares
the component for removing this dependency in the next major version.
This work is based on #80